From 132945342f73b3341576d0b6386474f9dcf2fe6c Mon Sep 17 00:00:00 2001 From: Sergey Elpashev Date: Sat, 22 Nov 2025 23:52:35 +0300 Subject: [PATCH] feat: fixed lint errors --- internal/apiserver/handlers/home.go | 5 ++++- internal/apiserver/handlers/time.go | 5 ++++- internal/apiserver/logger/logger.go | 6 ++---- internal/apiserver/middleware/request_id.go | 9 +++++++-- 4 files changed, 17 insertions(+), 8 deletions(-) diff --git a/internal/apiserver/handlers/home.go b/internal/apiserver/handlers/home.go index 8db805b..ba52373 100644 --- a/internal/apiserver/handlers/home.go +++ b/internal/apiserver/handlers/home.go @@ -33,5 +33,8 @@ func (h *HomeHandler) handleHome(w http.ResponseWriter, r *http.Request) { w.Header().Set("Content-Type", "application/json") w.WriteHeader(http.StatusOK) - json.NewEncoder(w).Encode(response) + if err := json.NewEncoder(w).Encode(response); err != nil { + // Handle encoding error - we can't write an error response after headers + return + } } diff --git a/internal/apiserver/handlers/time.go b/internal/apiserver/handlers/time.go index 5ef1b33..3d0ee39 100644 --- a/internal/apiserver/handlers/time.go +++ b/internal/apiserver/handlers/time.go @@ -39,5 +39,8 @@ func (h *TimeHandler) handleTime(w http.ResponseWriter, r *http.Request) { w.Header().Set("Content-Type", "application/json") w.WriteHeader(http.StatusOK) - json.NewEncoder(w).Encode(response) + if err := json.NewEncoder(w).Encode(response); err != nil { + // Handle encoding error - we can't write an error response after headers + return + } } diff --git a/internal/apiserver/logger/logger.go b/internal/apiserver/logger/logger.go index 8dd9941..907535d 100644 --- a/internal/apiserver/logger/logger.go +++ b/internal/apiserver/logger/logger.go @@ -37,10 +37,8 @@ func Initialize(level string, format string, output string) { }) } - // Set output - if output != "" { - //TODO: Use files - } + // Set output (currently not implemented) + // TODO: Implement file output support initialized = true }) diff --git a/internal/apiserver/middleware/request_id.go b/internal/apiserver/middleware/request_id.go index 0f8c0ca..e90ebab 100644 --- a/internal/apiserver/middleware/request_id.go +++ b/internal/apiserver/middleware/request_id.go @@ -8,6 +8,11 @@ import ( "github.com/google/uuid" ) +// requestIDKey is a custom type for context key to avoid collisions +type requestIDKey struct{} + +var _ requestIDKey + // RequestIDMiddleware adds a unique request ID to each request func RequestIDMiddleware(next http.Handler) http.Handler { return http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { @@ -17,9 +22,9 @@ func RequestIDMiddleware(next http.Handler) http.Handler { // Set request ID in response header w.Header().Set("X-Request-ID", requestID) - // Add request ID to context + // Add request ID to context using custom type ctx := r.Context() - ctx = context.WithValue(ctx, "request_id", requestID) + ctx = context.WithValue(ctx, requestIDKey{}, requestID) // Log the request ID assignment logger := logger.GetLogger()