6 Commits

Author SHA1 Message Date
space-nuko
334692eb1a Workflow serialization fix
ensure user data for values in workflow isn't stripped
2023-06-19 19:21:11 -05:00
space-nuko
3275777d2f Don't strip combo value from workflow 2023-06-08 22:20:45 -05:00
space-nuko
4a92bb68ee fixes 2023-06-08 19:33:26 -05:00
space-nuko
b126327ec2 Tag default workflow for previews use
Galleries should be tagged correctly to receive previews
2023-06-05 21:24:24 -05:00
space-nuko
27d0a4bd30 Thumbnail option for gallery/queue images 2023-06-05 21:15:49 -05:00
space-nuko
eb02561906 Basic preview support
(as of latest PR commit)
2023-06-05 15:45:08 -05:00
24 changed files with 402 additions and 126 deletions

View File

@@ -61,7 +61,7 @@
], ],
"title": "UI.Gallery", "title": "UI.Gallery",
"properties": { "properties": {
"tags": [], "tags": ["gen"],
"defaultValue": [], "defaultValue": [],
"index": 3, "index": 3,
"updateMode": "append", "updateMode": "append",
@@ -1694,7 +1694,7 @@
], ],
"title": "UI.Gallery", "title": "UI.Gallery",
"properties": { "properties": {
"tags": [], "tags": ["hr"],
"defaultValue": [], "defaultValue": [],
"index": 1, "index": 1,
"updateMode": "append", "updateMode": "append",

View File

@@ -101,6 +101,7 @@ export type ComfyUIPromptExtraData = {
} }
type ComfyAPIEvents = { type ComfyAPIEvents = {
// JSON
status: (status: ComfyAPIStatusResponse | null, error?: Error | null) => void, status: (status: ComfyAPIStatusResponse | null, error?: Error | null) => void,
progress: (progress: Progress) => void, progress: (progress: Progress) => void,
reconnecting: () => void, reconnecting: () => void,
@@ -111,6 +112,9 @@ type ComfyAPIEvents = {
execution_cached: (promptID: PromptID, nodes: ComfyNodeID[]) => void, execution_cached: (promptID: PromptID, nodes: ComfyNodeID[]) => void,
execution_interrupted: (error: ComfyInterruptedError) => void, execution_interrupted: (error: ComfyInterruptedError) => void,
execution_error: (error: ComfyExecutionError) => void, execution_error: (error: ComfyExecutionError) => void,
// Binary
b_preview: (imageBlob: Blob) => void
} }
export default class ComfyAPI { export default class ComfyAPI {
@@ -126,7 +130,7 @@ export default class ComfyAPI {
} }
/** /**
* Poll status for colab and other things that don't support websockets. * Poll status for colab and other things that don't support websockets.
*/ */
private pollQueue() { private pollQueue() {
setInterval(async () => { setInterval(async () => {
@@ -176,6 +180,7 @@ export default class ComfyAPI {
this.socket = new WebSocket( this.socket = new WebSocket(
`ws${window.location.protocol === "https:" ? "s" : ""}://${hostname}:${port}/ws${existingSession}` `ws${window.location.protocol === "https:" ? "s" : ""}://${hostname}:${port}/ws${existingSession}`
); );
this.socket.binaryType = "arraybuffer";
this.socket.addEventListener("open", () => { this.socket.addEventListener("open", () => {
opened = true; opened = true;
@@ -204,38 +209,64 @@ export default class ComfyAPI {
this.socket.addEventListener("message", (event) => { this.socket.addEventListener("message", (event) => {
try { try {
const msg = JSON.parse(event.data); if (event.data instanceof ArrayBuffer) {
switch (msg.type) { const view = new DataView(event.data);
case "status": const eventType = view.getUint32(0);
if (msg.data.sid) { const buffer = event.data.slice(4);
this.clientId = msg.data.sid; switch (eventType) {
sessionStorage["Comfy.SessionId"] = this.clientId; case 1:
} const view2 = new DataView(event.data);
this.eventBus.emit("status", { execInfo: { queueRemaining: msg.data.status.exec_info.queue_remaining } }); const imageType = view2.getUint32(0)
break; let imageMime: string
case "progress": switch (imageType) {
this.eventBus.emit("progress", msg.data as Progress); case 1:
break; default:
case "executing": imageMime = "image/jpeg";
this.eventBus.emit("executing", msg.data.prompt_id, msg.data.node); break;
break; case 2:
case "executed": imageMime = "image/png"
this.eventBus.emit("executed", msg.data.prompt_id, msg.data.node, msg.data.output); }
break; const imageBlob = new Blob([buffer.slice(4)], { type: imageMime });
case "execution_start": this.eventBus.emit("b_preview", imageBlob);
this.eventBus.emit("execution_start", msg.data.prompt_id); break;
break; default:
case "execution_cached": throw new Error(`Unknown binary websocket message of type ${eventType}`);
this.eventBus.emit("execution_cached", msg.data.prompt_id, msg.data.nodes); }
break; }
case "execution_interrupted": else {
this.eventBus.emit("execution_interrupted", msg.data); const msg = JSON.parse(event.data);
break; switch (msg.type) {
case "execution_error": case "status":
this.eventBus.emit("execution_error", msg.data); if (msg.data.sid) {
break; this.clientId = msg.data.sid;
default: sessionStorage["Comfy.SessionId"] = this.clientId;
console.warn("Unhandled message:", event.data); }
this.eventBus.emit("status", { execInfo: { queueRemaining: msg.data.status.exec_info.queue_remaining } });
break;
case "progress":
this.eventBus.emit("progress", msg.data as Progress);
break;
case "executing":
this.eventBus.emit("executing", msg.data.prompt_id, msg.data.node);
break;
case "executed":
this.eventBus.emit("executed", msg.data.prompt_id, msg.data.node, msg.data.output);
break;
case "execution_start":
this.eventBus.emit("execution_start", msg.data.prompt_id);
break;
case "execution_cached":
this.eventBus.emit("execution_cached", msg.data.prompt_id, msg.data.nodes);
break;
case "execution_interrupted":
this.eventBus.emit("execution_interrupted", msg.data);
break;
case "execution_error":
this.eventBus.emit("execution_error", msg.data);
break;
default:
console.warn("Unhandled message:", event.data);
}
} }
} catch (error) { } catch (error) {
console.error("Error handling message", event.data, error); console.error("Error handling message", event.data, error);

View File

@@ -651,6 +651,10 @@ export default class ComfyApp {
} }
}); });
this.api.addEventListener("b_preview", (imageBlob: Blob) => {
queueState.previewUpdated(imageBlob);
});
const config = get(configState); const config = get(configState);
if (config.pollSystemStatsInterval > 0) { if (config.pollSystemStatsInterval > 0) {

View File

@@ -386,6 +386,9 @@
<span style="display: inline-flex !important; padding: 0 0.75rem;"> <span style="display: inline-flex !important; padding: 0 0.75rem;">
<Checkbox label="Auto-Add UI" bind:value={$uiState.autoAddUI}/> <Checkbox label="Auto-Add UI" bind:value={$uiState.autoAddUI}/>
</span> </span>
<span style="display: inline-flex !important; padding: 0 0.75rem;">
<Checkbox label="Hide Previews" bind:value={$uiState.hidePreviews}/>
</span>
<!-- <span class="label" for="ui-edit-mode"> <!-- <span class="label" for="ui-edit-mode">
<BlockTitle>UI Edit mode</BlockTitle> <BlockTitle>UI Edit mode</BlockTitle>
<select id="ui-edit-mode" name="ui-edit-mode" bind:value={$uiState.uiEditMode}> <select id="ui-edit-mode" name="ui-edit-mode" bind:value={$uiState.uiEditMode}>

View File

@@ -1,18 +1,3 @@
<script lang="ts" context="module">
export type QueueUIEntryStatus = QueueEntryStatus | "pending" | "running";
export type QueueUIEntry = {
entry: QueueEntry,
message: string,
submessage: string,
date?: string,
status: QueueUIEntryStatus,
images?: string[], // URLs
details?: string, // shown in a tooltip on hover
error?: WorkflowError
}
</script>
<script lang="ts"> <script lang="ts">
import queueState, { type CompletedQueueEntry, type QueueEntry, type QueueEntryStatus } from "$lib/stores/queueState"; import queueState, { type CompletedQueueEntry, type QueueEntry, type QueueEntryStatus } from "$lib/stores/queueState";
import ProgressBar from "./ProgressBar.svelte"; import ProgressBar from "./ProgressBar.svelte";
@@ -20,7 +5,7 @@
import Spinner from "./Spinner.svelte"; import Spinner from "./Spinner.svelte";
import PromptDisplay from "./PromptDisplay.svelte"; import PromptDisplay from "./PromptDisplay.svelte";
import { List, ListUl, Grid } from "svelte-bootstrap-icons"; import { List, ListUl, Grid } from "svelte-bootstrap-icons";
import { convertComfyOutputToComfyURL, convertFilenameToComfyURL, getNodeInfo, truncateString } from "$lib/utils" import { getNodeInfo, type ComfyImageLocation } from "$lib/utils"
import type { Writable } from "svelte/store"; import type { Writable } from "svelte/store";
import type { QueueItemType } from "$lib/api"; import type { QueueItemType } from "$lib/api";
import { Button } from "@gradio/button"; import { Button } from "@gradio/button";
@@ -30,8 +15,8 @@
import { type WorkflowError } from "$lib/stores/workflowState"; import { type WorkflowError } from "$lib/stores/workflowState";
import ComfyQueueListDisplay from "./ComfyQueueListDisplay.svelte"; import ComfyQueueListDisplay from "./ComfyQueueListDisplay.svelte";
import ComfyQueueGridDisplay from "./ComfyQueueGridDisplay.svelte"; import ComfyQueueGridDisplay from "./ComfyQueueGridDisplay.svelte";
import { WORKFLOWS_VIEW } from "./ComfyBoxWorkflowsView.svelte"; import { WORKFLOWS_VIEW } from "./ComfyBoxWorkflowsView.svelte";
import uiQueueState from "$lib/stores/uiQueueState"; import uiQueueState, { type QueueUIEntry } from "$lib/stores/uiQueueState";
export let app: ComfyApp; export let app: ComfyApp;
@@ -125,7 +110,7 @@
let showModal = false; let showModal = false;
let expandAll = false; let expandAll = false;
let selectedPrompt = null; let selectedPrompt = null;
let selectedImages = []; let selectedImages: ComfyImageLocation[] = [];
function showPrompt(entry: QueueUIEntry) { function showPrompt(entry: QueueUIEntry) {
if (entry.error != null) { if (entry.error != null) {
showModal = false; showModal = false;

View File

@@ -1,6 +1,6 @@
<script lang="ts"> <script lang="ts">
import type { QueueItemType } from "$lib/api"; import type { QueueItemType } from "$lib/api";
import { showLightbox } from "$lib/utils"; import { convertComfyOutputToComfyURL, showLightbox } from "$lib/utils";
import type { QueueUIEntry } from "./ComfyQueue.svelte"; import type { QueueUIEntry } from "./ComfyQueue.svelte";
import queueState from "$lib/stores/queueState"; import queueState from "$lib/stores/queueState";
@@ -19,7 +19,7 @@
allEntries = [] allEntries = []
for (const entry of entries) { for (const entry of entries) {
for (const image of entry.images) { for (const image of entry.images) {
allEntries.push([entry, image]); allEntries.push([entry, convertComfyOutputToComfyURL(image, true)]);
} }
} }
allImages = allEntries.map(p => p[1]); allImages = allEntries.map(p => p[1]);
@@ -56,6 +56,7 @@
<img class="grid-entry-image" <img class="grid-entry-image"
on:click={(e) => handleClick(e, entry, i)} on:click={(e) => handleClick(e, entry, i)}
src={image} src={image}
loading="lazy"
alt="thumbnail" /> alt="thumbnail" />
</div> </div>
{/each} {/each}
@@ -130,6 +131,8 @@
.grid-entry-image { .grid-entry-image {
aspect-ratio: 1 / 1; aspect-ratio: 1 / 1;
object-fit: cover; object-fit: cover;
width: 100%;
max-width: unset;
&:hover { &:hover {
cursor: pointer; cursor: pointer;

View File

@@ -1,8 +1,8 @@
<script lang="ts"> <script lang="ts">
import type { QueueItemType } from "$lib/api"; import type { QueueItemType } from "$lib/api";
import { showLightbox, truncateString } from "$lib/utils"; import { convertComfyOutputToComfyURL, showLightbox, truncateString } from "$lib/utils";
import type { QueueUIEntry } from "./ComfyQueue.svelte";
import queueState from "$lib/stores/queueState"; import queueState from "$lib/stores/queueState";
import type { QueueUIEntry } from "$lib/stores/uiQueueState";
export let entries: QueueUIEntry[] = []; export let entries: QueueUIEntry[] = [];
export let showPrompt: (entry: QueueUIEntry) => void; export let showPrompt: (entry: QueueUIEntry) => void;
@@ -39,11 +39,13 @@
<div class="list-entry-images" <div class="list-entry-images"
style="--cols: {Math.ceil(Math.sqrt(Math.min(entry.images.length, 4)))}" > style="--cols: {Math.ceil(Math.sqrt(Math.min(entry.images.length, 4)))}" >
{#each entry.images.slice(0, 4) as image, i} {#each entry.images.slice(0, 4) as image, i}
{@const imageURL = convertComfyOutputToComfyURL(image, true)}
<div> <div>
<!-- svelte-ignore a11y-click-events-have-key-events --> <!-- svelte-ignore a11y-click-events-have-key-events -->
<img class="list-entry-image" <img class="list-entry-image"
on:click={(e) => showLightbox(entry.images, i, e)} on:click={(e) => showLightbox(entry.images, i, e)}
src={image} src={imageURL}
loading="lazy"
alt="thumbnail" /> alt="thumbnail" />
</div> </div>
{/each} {/each}

View File

@@ -8,7 +8,7 @@
import Gallery from "$lib/components/gradio/gallery/Gallery.svelte"; import Gallery from "$lib/components/gradio/gallery/Gallery.svelte";
import { ImageViewer } from "$lib/ImageViewer"; import { ImageViewer } from "$lib/ImageViewer";
import type { Styles } from "@gradio/utils"; import type { Styles } from "@gradio/utils";
import { comfyFileToComfyBoxMetadata, comfyURLToComfyFile, countNewLines } from "$lib/utils"; import { comfyFileToComfyBoxMetadata, comfyURLToComfyFile, countNewLines, type ComfyImageLocation, convertComfyOutputToComfyURL } from "$lib/utils";
import ReceiveOutputTargets from "./modal/ReceiveOutputTargets.svelte"; import ReceiveOutputTargets from "./modal/ReceiveOutputTargets.svelte";
import workflowState, { type ComfyBoxWorkflow, type WorkflowReceiveOutputTargets } from "$lib/stores/workflowState"; import workflowState, { type ComfyBoxWorkflow, type WorkflowReceiveOutputTargets } from "$lib/stores/workflowState";
import type { ComfyReceiveOutputNode } from "$lib/nodes/actions"; import type { ComfyReceiveOutputNode } from "$lib/nodes/actions";
@@ -17,7 +17,7 @@
const splitLength = 50; const splitLength = 50;
export let prompt: SerializedPromptInputsAll; export let prompt: SerializedPromptInputsAll;
export let images: string[] = []; // list of image URLs to ComfyUI's /view? endpoint export let images: ComfyImageLocation[] = [];
export let isMobile: boolean = false; export let isMobile: boolean = false;
export let expandAll: boolean = false; export let expandAll: boolean = false;
export let closeModal: () => void; export let closeModal: () => void;
@@ -36,10 +36,7 @@
let litegraphType = "(none)" let litegraphType = "(none)"
$: if (images.length > 0) { $: if (images.length > 0) {
// since the image links come from gradio, have to parse the URL for the comfyBoxImages = images.map(comfyFileToComfyBoxMetadata);
// ComfyImageLocation params
comfyBoxImages = images.map(comfyURLToComfyFile)
.map(comfyFileToComfyBoxMetadata);
} }
else { else {
comfyBoxImages = [] comfyBoxImages = []
@@ -199,7 +196,7 @@
<div class="image-container"> <div class="image-container">
<Block> <Block>
<Gallery <Gallery
value={images} value={images.map(convertComfyOutputToComfyURL)}
label="" label=""
show_label={false} show_label={false}
style={galleryStyle} style={galleryStyle}

View File

@@ -73,10 +73,10 @@ export default class ComfySetNodeModeAdvancedAction extends ComfyGraphNode {
if (hasTag) { if (hasTag) {
let newMode: NodeMode; let newMode: NodeMode;
if (enable && action.enable) { if (action.enable) {
newMode = NodeMode.ALWAYS; newMode = enable ? NodeMode.ALWAYS : NodeMode.NEVER;
} else { } else {
newMode = NodeMode.NEVER; newMode = enable ? NodeMode.NEVER : NodeMode.ALWAYS;
} }
nodeChanges[node.id] = newMode nodeChanges[node.id] = newMode
} }
@@ -88,7 +88,12 @@ export default class ComfySetNodeModeAdvancedAction extends ComfyGraphNode {
const container = entry.dragItem; const container = entry.dragItem;
const hasTag = container.attrs.tags.indexOf(action.tag) != -1; const hasTag = container.attrs.tags.indexOf(action.tag) != -1;
if (hasTag) { if (hasTag) {
const hidden = !(enable && action.enable) let hidden: boolean;
if (action.enable) {
hidden = !enable
} else {
hidden = enable;
}
widgetChanges[container.id] = hidden widgetChanges[container.id] = hidden
} }
} }

View File

@@ -170,7 +170,6 @@ export default class ComfyComboNode extends ComfyWidgetNode<string> {
super.stripUserState(o); super.stripUserState(o);
o.properties.values = [] o.properties.values = []
o.properties.defaultValue = null; o.properties.defaultValue = null;
(o as any).comfyValue = null
} }
} }

View File

@@ -9,7 +9,8 @@ import ComfyWidgetNode from "./ComfyWidgetNode";
export interface ComfyGalleryProperties extends ComfyWidgetProperties { export interface ComfyGalleryProperties extends ComfyWidgetProperties {
index: number | null, index: number | null,
updateMode: "replace" | "append", updateMode: "replace" | "append",
autoSelectOnUpdate: boolean autoSelectOnUpdate: boolean,
showPreviews: boolean
} }
export default class ComfyGalleryNode extends ComfyWidgetNode<ComfyBoxImageMetadata[]> { export default class ComfyGalleryNode extends ComfyWidgetNode<ComfyBoxImageMetadata[]> {
@@ -18,7 +19,8 @@ export default class ComfyGalleryNode extends ComfyWidgetNode<ComfyBoxImageMetad
defaultValue: [], defaultValue: [],
index: 0, index: 0,
updateMode: "replace", updateMode: "replace",
autoSelectOnUpdate: true autoSelectOnUpdate: true,
showPreviews: true
} }
static slotLayout: SlotLayout = { static slotLayout: SlotLayout = {

View File

@@ -357,9 +357,4 @@ export default abstract class ComfyWidgetNode<T = any> extends ComfyGraphNode {
this.value.set(value); this.value.set(value);
this.shownOutputProperties = (o as any).shownOutputProperties; this.shownOutputProperties = (o as any).shownOutputProperties;
} }
override stripUserState(o: SerializedLGraphNode) {
super.stripUserState(o);
(o as any).comfyValue = LiteGraph.cloneObject(this.properties.defaultValue);
}
} }

View File

@@ -119,6 +119,36 @@ const defNotifications: ConfigDefEnum<"notifications", NotificationState> = {
} }
}; };
export enum OutputThumbnailsMode {
Auto,
AlwaysThumbnail,
AlwaysFullSize
}
const defOutputThumbnails: ConfigDefEnum<"outputThumbnails", OutputThumbnailsMode> = {
name: "outputThumbnails",
type: "enum",
defaultValue: OutputThumbnailsMode.Auto,
category: "ui",
description: "If enabled, send back smaller sized output image thumbnails for gallery/queue/history. Enable if you have slow network or are using Colab.",
options: {
values: [
{
value: OutputThumbnailsMode.Auto,
label: "Autodetect"
},
{
value: OutputThumbnailsMode.AlwaysThumbnail,
label: "Always use thumbnails"
},
{
value: OutputThumbnailsMode.AlwaysFullSize,
label: "Always use full size"
},
]
}
};
const defAlwaysStripUserState: ConfigDefBoolean<"alwaysStripUserState"> = { const defAlwaysStripUserState: ConfigDefBoolean<"alwaysStripUserState"> = {
name: "alwaysStripUserState", name: "alwaysStripUserState",
type: "boolean", type: "boolean",
@@ -207,6 +237,7 @@ export const CONFIG_DEFS = [
defComfyUIHostname, defComfyUIHostname,
defComfyUIPort, defComfyUIPort,
defNotifications, defNotifications,
defOutputThumbnails,
defAlwaysStripUserState, defAlwaysStripUserState,
defPromptForWorkflowName, defPromptForWorkflowName,
defConfirmWhenUnloadingUnsavedChanges, defConfirmWhenUnloadingUnsavedChanges,

View File

@@ -615,6 +615,14 @@ const ALL_ATTRIBUTES: AttributesSpecList = [
validNodeTypes: ["ui/gallery"], validNodeTypes: ["ui/gallery"],
defaultValue: true defaultValue: true
}, },
{
name: "showPreviews",
type: "boolean",
location: "nodeProps",
editable: true,
validNodeTypes: ["ui/gallery"],
defaultValue: true
},
// ImageUpload // ImageUpload
{ {

View File

@@ -22,6 +22,7 @@ type QueueStateOps = {
executionCached: (promptID: PromptID, nodes: ComfyNodeID[]) => void, executionCached: (promptID: PromptID, nodes: ComfyNodeID[]) => void,
executionError: (error: ComfyExecutionError) => CompletedQueueEntry | null, executionError: (error: ComfyExecutionError) => CompletedQueueEntry | null,
progressUpdated: (progress: Progress) => void progressUpdated: (progress: Progress) => void
previewUpdated: (imageBlob: Blob) => void
getQueueEntry: (promptID: PromptID) => QueueEntry | null; getQueueEntry: (promptID: PromptID) => QueueEntry | null;
afterQueued: (workflowID: WorkflowInstID, promptID: PromptID, number: number, prompt: SerializedPromptInputsAll, extraData: any) => void afterQueued: (workflowID: WorkflowInstID, promptID: PromptID, number: number, prompt: SerializedPromptInputsAll, extraData: any) => void
queueItemDeleted: (type: QueueItemType, id: PromptID) => void; queueItemDeleted: (type: QueueItemType, id: PromptID) => void;
@@ -88,6 +89,11 @@ export type QueueState = {
*/ */
runningNodeID: ComfyNodeID | null; runningNodeID: ComfyNodeID | null;
/*
* Currently executing prompt if any
*/
runningPromptID: PromptID | null;
/* /*
* Nodes which should be rendered as "executing" in the frontend (green border). * Nodes which should be rendered as "executing" in the frontend (green border).
* This includes the running node and all its parent subgraphs * This includes the running node and all its parent subgraphs
@@ -98,6 +104,12 @@ export type QueueState = {
* Progress for the current node reported by the frontend * Progress for the current node reported by the frontend
*/ */
progress: Progress | null, progress: Progress | null,
/*
* Image preview URL
*/
previewURL: string | null,
/** /**
* If true, user pressed the "Interrupt" button in the frontend. Disable the * If true, user pressed the "Interrupt" button in the frontend. Disable the
* button and wait until the next prompt starts running to re-enable it * button and wait until the next prompt starts running to re-enable it
@@ -115,6 +127,7 @@ const store: Writable<QueueState> = writable({
runningNodeID: null, runningNodeID: null,
executingNodes: new Set(), executingNodes: new Set(),
progress: null, progress: null,
preview: null,
isInterrupting: false isInterrupting: false
}) })
@@ -171,6 +184,19 @@ function progressUpdated(progress: Progress) {
}) })
} }
function previewUpdated(imageBlob: Blob) {
console.debug("[queueState] previewUpdated", imageBlob?.type)
store.update(s => {
if (s.runningNodeID == null) {
s.previewURL = null;
return s;
}
s.previewURL = URL.createObjectURL(imageBlob);
return s;
})
}
function statusUpdated(status: ComfyAPIStatusResponse | null) { function statusUpdated(status: ComfyAPIStatusResponse | null) {
console.debug("[queueState] statusUpdated", status) console.debug("[queueState] statusUpdated", status)
store.update((s) => { store.update((s) => {
@@ -296,6 +322,7 @@ function executingUpdated(promptID: PromptID, runningNodeID: ComfyNodeID | null)
entry.nodesRan.add(runningNodeID) entry.nodesRan.add(runningNodeID)
} }
s.runningNodeID = runningNodeID; s.runningNodeID = runningNodeID;
s.runningPromptID = promptID;
if (entry?.extraData?.workflowID) { if (entry?.extraData?.workflowID) {
const workflow = workflowState.getWorkflow(entry.extraData.workflowID); const workflow = workflowState.getWorkflow(entry.extraData.workflowID);
@@ -337,7 +364,9 @@ function executingUpdated(promptID: PromptID, runningNodeID: ComfyNodeID | null)
console.debug("[queueState] Could not find in pending! (executingUpdated)", promptID) console.debug("[queueState] Could not find in pending! (executingUpdated)", promptID)
} }
s.progress = null; s.progress = null;
s.previewURL = null;
s.runningNodeID = null; s.runningNodeID = null;
s.runningPromptID = null;
s.executingNodes.clear(); s.executingNodes.clear();
} }
entry_ = entry; entry_ = entry;
@@ -362,7 +391,9 @@ function executionCached(promptID: PromptID, nodes: ComfyNodeID[]) {
} }
s.isInterrupting = false; // TODO move to start s.isInterrupting = false; // TODO move to start
s.progress = null; s.progress = null;
s.previewURL = null;
s.runningNodeID = null; s.runningNodeID = null;
s.runningPromptID = null;
s.executingNodes.clear(); s.executingNodes.clear();
return s return s
}) })
@@ -380,7 +411,9 @@ function executionError(error: ComfyExecutionError): CompletedQueueEntry | null
console.error("[queueState] Could not find in pending! (executionError)", error.prompt_id) console.error("[queueState] Could not find in pending! (executionError)", error.prompt_id)
} }
s.progress = null; s.progress = null;
s.previewURL = null;
s.runningNodeID = null; s.runningNodeID = null;
s.runningPromptID = null;
s.executingNodes.clear(); s.executingNodes.clear();
return s return s
}) })
@@ -416,6 +449,7 @@ function executionStart(promptID: PromptID) {
} }
s.isInterrupting = false; s.isInterrupting = false;
s.runningNodeID = null; s.runningNodeID = null;
s.runningPromptID = promptID;
s.executingNodes.clear(); s.executingNodes.clear();
return s return s
}) })
@@ -480,7 +514,9 @@ function queueCleared(type: QueueItemType) {
s.queuePending.set([]); s.queuePending.set([]);
s.queueRemaining = 0; s.queueRemaining = 0;
s.runningNodeID = null; s.runningNodeID = null;
s.runningPromptID = null;
s.progress = null; s.progress = null;
s.previewURL = null;
s.executingNodes.clear(); s.executingNodes.clear();
} }
else { else {
@@ -535,6 +571,7 @@ const queueStateStore: WritableQueueStateStore =
historyUpdated, historyUpdated,
statusUpdated, statusUpdated,
progressUpdated, progressUpdated,
previewUpdated,
executionStart, executionStart,
executingUpdated, executingUpdated,
executionCached, executionCached,

View File

@@ -1,7 +1,8 @@
import type { PromptID, QueueItemType } from '$lib/api'; import type { PromptID, QueueItemType } from '$lib/api';
import type { ComfyImageLocation } from "$lib/utils";
import { get, writable } from 'svelte/store'; import { get, writable } from 'svelte/store';
import type { Readable, Writable } from 'svelte/store'; import type { Readable, Writable } from 'svelte/store';
import queueState, { type CompletedQueueEntry, type QueueEntry } from './queueState'; import queueState, { QueueEntryStatus, type CompletedQueueEntry, type QueueEntry } from './queueState';
import type { WorkflowError } from './workflowState'; import type { WorkflowError } from './workflowState';
import { convertComfyOutputToComfyURL } from '$lib/utils'; import { convertComfyOutputToComfyURL } from '$lib/utils';
@@ -13,7 +14,7 @@ export type QueueUIEntry = {
submessage: string, submessage: string,
date?: string, date?: string,
status: QueueUIEntryStatus, status: QueueUIEntryStatus,
images?: string[], // URLs images?: ComfyImageLocation[], // URLs
details?: string, // shown in a tooltip on hover details?: string, // shown in a tooltip on hover
error?: WorkflowError error?: WorkflowError
} }
@@ -94,13 +95,12 @@ function convertPendingEntry(entry: QueueEntry, status: QueueUIEntryStatus): Que
const thumbnails = entry.extraData?.thumbnails const thumbnails = entry.extraData?.thumbnails
if (thumbnails) { if (thumbnails) {
result.images = thumbnails.map(convertComfyOutputToComfyURL); result.images = [...thumbnails]
} }
const outputs = Object.values(entry.outputs) const outputs = Object.values(entry.outputs)
.filter(o => o.images) .filter(o => o.images)
.flatMap(o => o.images) .flatMap(o => o.images)
.map(convertComfyOutputToComfyURL);
if (outputs) { if (outputs) {
result.images = result.images.concat(outputs) result.images = result.images.concat(outputs)
} }
@@ -114,7 +114,6 @@ function convertCompletedEntry(entry: CompletedQueueEntry): QueueUIEntry {
const images = Object.values(entry.entry.outputs) const images = Object.values(entry.entry.outputs)
.filter(o => o.images) .filter(o => o.images)
.flatMap(o => o.images) .flatMap(o => o.images)
.map(convertComfyOutputToComfyURL);
result.images = images result.images = images
if (entry.message) if (entry.message)
@@ -132,6 +131,8 @@ function updateFromQueue(queuePending: QueueEntry[], queueRunning: QueueEntry[])
// newest entries appear at the top // newest entries appear at the top
s.queuedEntries = queuePending.map((e) => convertPendingEntry(e, "pending")).reverse(); s.queuedEntries = queuePending.map((e) => convertPendingEntry(e, "pending")).reverse();
s.runningEntries = queueRunning.map((e) => convertPendingEntry(e, "running")).reverse(); s.runningEntries = queueRunning.map((e) => convertPendingEntry(e, "running")).reverse();
s.queuedEntries.sort((a, b) => a.entry.number - b.entry.number)
s.runningEntries.sort((a, b) => a.entry.number - b.entry.number)
s.queueUIEntries = s.queuedEntries.concat(s.runningEntries); s.queueUIEntries = s.queuedEntries.concat(s.runningEntries);
console.warn("[ComfyQueue] BUILDQUEUE", s.queuedEntries.length, s.runningEntries.length) console.warn("[ComfyQueue] BUILDQUEUE", s.queuedEntries.length, s.runningEntries.length)
return s; return s;

View File

@@ -10,6 +10,7 @@ export type UIState = {
autoAddUI: boolean, autoAddUI: boolean,
uiUnlocked: boolean, uiUnlocked: boolean,
uiEditMode: UIEditMode, uiEditMode: UIEditMode,
hidePreviews: boolean,
reconnecting: boolean, reconnecting: boolean,
forceSaveUserState: boolean | null, forceSaveUserState: boolean | null,
@@ -30,6 +31,7 @@ const store: Writable<UIState> = writable(
autoAddUI: true, autoAddUI: true,
uiUnlocked: false, uiUnlocked: false,
uiEditMode: "widgets", uiEditMode: "widgets",
hidePreviews: false,
reconnecting: false, reconnecting: false,
forceSaveUserState: null, forceSaveUserState: null,

View File

@@ -9,6 +9,7 @@ import workflowState, { type WorkflowReceiveOutputTargets } from "./stores/workf
import { ImageViewer } from "./ImageViewer"; import { ImageViewer } from "./ImageViewer";
import configState from "$lib/stores/configState"; import configState from "$lib/stores/configState";
import SendOutputModal, { type SendOutputModalResult } from "$lib/components/modal/SendOutputModal.svelte"; import SendOutputModal, { type SendOutputModalResult } from "$lib/components/modal/SendOutputModal.svelte";
import { OutputThumbnailsMode } from "./stores/configDefs";
export function clamp(n: number, min: number, max: number): number { export function clamp(n: number, min: number, max: number): number {
if (max <= min) if (max <= min)
@@ -300,31 +301,80 @@ export function convertComfyOutputToGradio(output: SerializedPromptOutput): Grad
export function convertComfyOutputEntryToGradio(r: ComfyImageLocation): GradioFileData { export function convertComfyOutputEntryToGradio(r: ComfyImageLocation): GradioFileData {
const url = configState.getBackendURL(); const url = configState.getBackendURL();
const params = new URLSearchParams(r)
const fileData: GradioFileData = { const fileData: GradioFileData = {
name: r.filename, name: r.filename,
orig_name: r.filename, orig_name: r.filename,
is_file: false, is_file: false,
data: url + "/view?" + params data: convertComfyOutputToComfyURL(r)
} }
return fileData return fileData
} }
export function convertComfyOutputToComfyURL(output: string | ComfyImageLocation): string { function convertComfyPreviewTypeToString(preview: ComfyImagePreviewType): string {
const arr = []
switch (preview.format) {
case ComfyImagePreviewFormat.JPEG:
arr.push("jpeg")
break;
case ComfyImagePreviewFormat.WebP:
default:
arr.push("webp")
break;
}
arr.push(String(preview.quality))
return arr.join(";")
}
export function convertComfyOutputToComfyURL(output: string | ComfyImageLocation, thumbnail: boolean = false): string {
if (typeof output === "string") if (typeof output === "string")
return output; return output;
const params = new URLSearchParams(output) const paramsObj = {
filename: output.filename,
subfolder: output.subfolder,
type: output.type
}
if (thumbnail) {
let doThumbnail: boolean;
switch (get(configState).outputThumbnails) {
case OutputThumbnailsMode.AlwaysFullSize:
doThumbnail = false;
break;
case OutputThumbnailsMode.AlwaysThumbnail:
doThumbnail = true;
break;
case OutputThumbnailsMode.Auto:
default:
// TODO detect colab, etc.
if (isMobileBrowser(navigator.userAgent)) {
doThumbnail = true;
}
else {
doThumbnail = false;
}
break;
}
if (doThumbnail) {
output.preview = {
format: ComfyImagePreviewFormat.WebP,
quality: 80
}
}
}
if (output.preview != null)
paramsObj["preview"] = convertComfyPreviewTypeToString(output.preview)
const params = new URLSearchParams(paramsObj)
const url = configState.getBackendURL(); const url = configState.getBackendURL();
return url + "/view?" + params return url + "/view?" + params
} }
export function convertGradioFileDataToComfyURL(image: GradioFileData, type: ComfyUploadImageType = "input"): string {
const baseUrl = configState.getBackendURL();
const params = new URLSearchParams({ filename: image.name, subfolder: "", type })
return `${baseUrl}/view?${params}`
}
export function convertGradioFileDataToComfyOutput(fileData: GradioFileData, type: ComfyUploadImageType = "input"): ComfyImageLocation { export function convertGradioFileDataToComfyOutput(fileData: GradioFileData, type: ComfyUploadImageType = "input"): ComfyImageLocation {
if (!fileData.is_file) if (!fileData.is_file)
throw "Can't convert blob data to comfy output!" throw "Can't convert blob data to comfy output!"
@@ -336,18 +386,6 @@ export function convertGradioFileDataToComfyOutput(fileData: GradioFileData, typ
} }
} }
export function convertFilenameToComfyURL(filename: string,
subfolder: string = "",
type: "input" | "output" | "temp" = "output"): string {
const params = new URLSearchParams({
filename,
subfolder,
type
})
const url = configState.getBackendURL();
return url + "/view?" + params
}
export function jsonToJsObject(json: string): string { export function jsonToJsObject(json: string): string {
// Try to parse, to see if it's real JSON // Try to parse, to see if it's real JSON
JSON.parse(json); JSON.parse(json);
@@ -413,6 +451,16 @@ export interface SerializedPromptOutput {
[key: string]: any [key: string]: any
} }
export enum ComfyImagePreviewFormat {
WebP = "webp",
JPEG = "jpeg",
}
export type ComfyImagePreviewType = {
format: ComfyImagePreviewFormat,
quality: number
}
/** Raw output entry as received from ComfyUI's backend */ /** Raw output entry as received from ComfyUI's backend */
export type ComfyImageLocation = { export type ComfyImageLocation = {
/* Filename with extension in the subfolder. */ /* Filename with extension in the subfolder. */
@@ -420,7 +468,19 @@ export type ComfyImageLocation = {
/* Subfolder in the containing folder. */ /* Subfolder in the containing folder. */
subfolder: string, subfolder: string,
/* Base ComfyUI folder where the image is located. */ /* Base ComfyUI folder where the image is located. */
type: ComfyUploadImageType type: ComfyUploadImageType,
/*
* Preview information
*
* "format;quality"
*
* ex)
* webp;50 -> webp, quality 50
* webp;50 -> webp, quality 50
* jpeg;80 -> rgb, jpeg, quality 80
*
*/
preview?: ComfyImagePreviewType
} }
/* /*
@@ -544,27 +604,54 @@ export function comfyBoxImageToComfyURL(image: ComfyBoxImageMetadata): string {
return convertComfyOutputToComfyURL(image.comfyUIFile) return convertComfyOutputToComfyURL(image.comfyUIFile)
} }
function parseComfyUIPreviewType(previewStr: string): ComfyImagePreviewType {
let split = previewStr.split(";")
let format = ComfyImagePreviewFormat.WebP;
if (split[0] === "webp")
format = ComfyImagePreviewFormat.WebP;
else if (split[0] === "jpeg")
format = ComfyImagePreviewFormat.JPEG;
let quality = parseInt(split[0])
if (isNaN(quality))
quality = 80
return { format, quality }
}
export function comfyURLToComfyFile(urlString: string): ComfyImageLocation | null { export function comfyURLToComfyFile(urlString: string): ComfyImageLocation | null {
const url = new URL(urlString); const url = new URL(urlString);
const params = new URLSearchParams(url.search); const params = new URLSearchParams(url.search);
const filename = params.get("filename") const filename = params.get("filename")
const type = params.get("type") as ComfyUploadImageType; const type = params.get("type") as ComfyUploadImageType;
const subfolder = params.get("subfolder") || "" const subfolder = params.get("subfolder") || ""
const previewStr = params.get("preview") || null;
let preview = null
if (previewStr != null) {
preview = parseComfyUIPreviewType(preview);
}
// If at least filename and type exist then we're good // If at least filename and type exist then we're good
if (filename != null && type != null) { if (filename != null && type != null) {
return { filename, type, subfolder } return { filename, type, subfolder, preview }
} }
return null; return null;
} }
export function showLightbox(images: string[], index: number, e: Event) { export function showLightbox(images: ComfyImageLocation[] | string[], index: number, e: Event) {
e.preventDefault() e.preventDefault()
if (!images) if (!images)
return return
ImageViewer.instance.showModal(images, index); let images_: string[]
if (typeof images[0] === "object")
images_ = (images as ComfyImageLocation[]).map(v => convertComfyOutputToComfyURL(v))
else
images_ = (images as string[])
ImageViewer.instance.showModal(images_, index);
e.stopPropagation() e.stopPropagation()
} }

View File

@@ -11,7 +11,11 @@
import { clamp, comfyBoxImageToComfyURL, type ComfyBoxImageMetadata } from "$lib/utils"; import { clamp, comfyBoxImageToComfyURL, type ComfyBoxImageMetadata } from "$lib/utils";
import { f7 } from "framework7-svelte"; import { f7 } from "framework7-svelte";
import type { ComfyGalleryNode } from "$lib/nodes/widgets"; import type { ComfyGalleryNode } from "$lib/nodes/widgets";
import { showMobileLightbox } from "$lib/components/utils"; import { showMobileLightbox } from "$lib/components/utils";
import queueState from "$lib/stores/queueState";
import uiState from "$lib/stores/uiState";
import { loadImage } from "./utils";
import Spinner from "$lib/components/Spinner.svelte";
export let widget: WidgetLayout | null = null; export let widget: WidgetLayout | null = null;
export let isMobile: boolean = false; export let isMobile: boolean = false;
@@ -25,6 +29,41 @@
$: widget && setNodeValue(widget); $: widget && setNodeValue(widget);
function tagsMatch(tags: string[] | null): boolean {
if(tags != null && tags.length > 0)
return node.properties.tags.length > 0 && node.properties.tags.every(t => tags.includes(t));
else
return node.properties.tags.length === 0;
}
let previewURL: string | null;
let previewImage: HTMLImageElement | null = null;
let previewElem: HTMLImageElement | null = null
$: {
previewURL = $queueState.previewURL;
if (previewURL && $queueState.runningPromptID && !$uiState.hidePreviews && node.properties.showPreviews) {
const queueEntry = queueState.getQueueEntry($queueState.runningPromptID)
if (queueEntry != null) {
const tags = queueEntry.extraData?.extra_pnginfo?.comfyBoxPrompt?.subgraphs;
if (tagsMatch(tags)) {
loadImage(previewURL).then((img) => {
previewImage = img;
})
}
}
}
else {
previewImage = null;
}
}
function showPreview() {
}
function hidePreview() {
}
function setNodeValue(widget: WidgetLayout) { function setNodeValue(widget: WidgetLayout) {
if (widget) { if (widget) {
node = widget.node as ComfyGalleryNode node = widget.node as ComfyGalleryNode
@@ -34,6 +73,8 @@
imageHeight = node.imageHeight imageHeight = node.imageHeight
selected_image = node.selectedImage; selected_image = node.selectedImage;
forceSelectImage = node.forceSelectImage; forceSelectImage = node.forceSelectImage;
previewURL = null;
previewImage = null;
if ($nodeValue != null) { if ($nodeValue != null) {
if (node.properties.index < 0 || node.properties.index >= $nodeValue.length) { if (node.properties.index < 0 || node.properties.index >= $nodeValue.length) {
@@ -108,6 +149,11 @@
<div class="wrapper comfy-gallery-widget gradio-gallery" style={widget.attrs.style || ""}> <div class="wrapper comfy-gallery-widget gradio-gallery" style={widget.attrs.style || ""}>
<Block variant="solid" padding={false}> <Block variant="solid" padding={false}>
<div class="padding"> <div class="padding">
{#if previewImage && $queueState.runningPromptID != null}
<div class="comfy-gallery-preview" on:mouseover={hidePreview} on:mouseout={showPreview} >
<img src={previewImage.src} bind:this={previewElem} on:mouseout={showPreview} />
</div>
{/if}
<Gallery <Gallery
value={images} value={images}
label={widget.attrs.title} label={widget.attrs.title}
@@ -153,6 +199,29 @@
} }
} }
} }
&:hover .comfy-gallery-preview {
opacity: 0%;
}
}
.comfy-gallery-preview {
position: absolute;
top: 0;
left: 0;
width: 100%;
height: 100%;
z-index: var(--layer-top);
pointer-events: none;
transition: opacity 0.1s linear;
opacity: 100%;
> img {
width: var(--size-full);
height: var(--size-full);
object-fit: contain;
border: 5px dashed var(--secondary-400);
}
} }
.padding { .padding {

View File

@@ -230,7 +230,7 @@
/> />
{:else} {:else}
<div class="comfy-image-editor-panel"> <div class="comfy-image-editor-panel">
{#if _value && canMask} {#if _value && _value.length > 0 && canMask}
{@const comfyURL = convertComfyOutputToComfyURL(_value[0])} {@const comfyURL = convertComfyOutputToComfyURL(_value[0])}
<div class="mask-canvas-wrapper" style:display={editMask ? "block" : "none"}> <div class="mask-canvas-wrapper" style:display={editMask ? "block" : "none"}>
<MaskCanvas bind:this={maskCanvasComp} fileURL={comfyURL} on:release={onMaskReleased} on:loaded={onMaskReleased} /> <MaskCanvas bind:this={maskCanvasComp} fileURL={comfyURL} on:release={onMaskReleased} on:loaded={onMaskReleased} />

View File

@@ -1,17 +1,11 @@
<script lang="ts"> <script lang="ts">
import { Page, Navbar, Block, Tabs, Tab, NavLeft, NavTitle, NavRight, Link, f7 } from "framework7-svelte" import { Page, Navbar, Block, Tabs, Tab, NavLeft, NavTitle, NavRight, Link, f7 } from "framework7-svelte"
import WidgetContainer from "$lib/components/WidgetContainer.svelte";
import type ComfyApp from "$lib/components/ComfyApp"; import type ComfyApp from "$lib/components/ComfyApp";
import { writable, type Writable } from "svelte/store";
import type { IDragItem, WritableLayoutStateStore } from "$lib/stores/layoutStates";
import workflowState, { type ComfyBoxWorkflow, type WorkflowInstID } from "$lib/stores/workflowState";
import interfaceState from "$lib/stores/interfaceState"; import interfaceState from "$lib/stores/interfaceState";
import { onMount } from "svelte"; import { convertComfyOutputToComfyURL, partition, showLightbox } from "$lib/utils";
import GenToolbar from '../GenToolbar.svelte' import uiQueueState, { type QueueUIEntry } from "$lib/stores/uiQueueState";
import { partition, showLightbox } from "$lib/utils"; import { showMobileLightbox } from "$lib/components/utils";
import uiQueueState, { type QueueUIEntry } from "$lib/stores/uiQueueState"; import notify from "$lib/notify";
import { showMobileLightbox } from "$lib/components/utils";
import notify from "$lib/notify";
export let app: ComfyApp export let app: ComfyApp
@@ -33,7 +27,7 @@
const _allEntries = [] const _allEntries = []
for (const entry of entries) { for (const entry of entries) {
for (const image of entry.images) { for (const image of entry.images) {
_allEntries.push([entry, image]); _allEntries.push([entry, convertComfyOutputToComfyURL(image, true)]);
} }
} }
allEntries = partition(_allEntries, gridCols); allEntries = partition(_allEntries, gridCols);

View File

@@ -8,7 +8,7 @@
import interfaceState from "$lib/stores/interfaceState"; import interfaceState from "$lib/stores/interfaceState";
import { onMount } from "svelte"; import { onMount } from "svelte";
import GenToolbar from '../GenToolbar.svelte' import GenToolbar from '../GenToolbar.svelte'
import { partition, showLightbox, truncateString } from "$lib/utils"; import { convertComfyOutputToComfyURL, partition, showLightbox, truncateString } from "$lib/utils";
import uiQueueState, { type QueueUIEntry } from "$lib/stores/uiQueueState"; import uiQueueState, { type QueueUIEntry } from "$lib/stores/uiQueueState";
import { showMobileLightbox } from "$lib/components/utils"; import { showMobileLightbox } from "$lib/components/utils";
import queueState from "$lib/stores/queueState"; import queueState from "$lib/stores/queueState";
@@ -68,7 +68,7 @@
function getCardImage(entry: QueueUIEntry): string { function getCardImage(entry: QueueUIEntry): string {
if (entry.images.length > 0) if (entry.images.length > 0)
return entry.images[0] return convertComfyOutputToComfyURL(entry.images[0])
return "https://cdn.framework7.io/placeholder/nature-1000x600-3.jpg" return "https://cdn.framework7.io/placeholder/nature-1000x600-3.jpg"
} }
</script> </script>

View File

@@ -1,11 +1,12 @@
import ComfyGraph from "$lib/ComfyGraph"; import ComfyGraph from "$lib/ComfyGraph";
import { ComfyNumberNode } from "$lib/nodes/widgets"; import { ComfyNumberNode, ComfyComboNode } from "$lib/nodes/widgets";
import { ComfyBoxWorkflow } from "$lib/stores/workflowState"; import { ComfyBoxWorkflow } from "$lib/stores/workflowState";
import { LiteGraph, Subgraph } from "@litegraph-ts/core"; import { LiteGraph, Subgraph } from "@litegraph-ts/core";
import { get } from "svelte/store"; import { get } from "svelte/store";
import { expect } from 'vitest'; import { expect } from 'vitest';
import UnitTest from "./UnitTest"; import UnitTest from "./UnitTest";
import { Watch } from "@litegraph-ts/nodes-basic"; import { Watch } from "@litegraph-ts/nodes-basic";
import type { SerializedComfyWidgetNode } from "$lib/nodes/widgets/ComfyWidgetNode";
export default class ComfyGraphTests extends UnitTest { export default class ComfyGraphTests extends UnitTest {
test__onNodeAdded__updatesLayoutState() { test__onNodeAdded__updatesLayoutState() {
@@ -107,4 +108,24 @@ export default class ComfyGraphTests extends UnitTest {
expect(serNode.outputs[0]._data).toBeUndefined() expect(serNode.outputs[0]._data).toBeUndefined()
} }
test__serialize__savesComboData() {
const [{ graph }, layoutState] = ComfyBoxWorkflow.create()
layoutState.initDefaultLayout()
const widget = LiteGraph.createNode(ComfyComboNode);
const watch = LiteGraph.createNode(Watch);
graph.add(widget)
graph.add(watch)
widget.connect(0, watch, 0)
widget.properties.values = ["A", "B", "C"]
widget.setValue("B");
const result = graph.serialize();
const serNode = result.nodes.find(n => n.id === widget.id) as SerializedComfyWidgetNode;
expect(serNode.comfyValue).toBe("B")
}
} }