From c644f2e891f5780f1378a4dd7cb3fe4a02af7a8e Mon Sep 17 00:00:00 2001 From: space-nuko <24979496+space-nuko@users.noreply.github.com> Date: Sat, 20 May 2023 09:39:28 -0500 Subject: [PATCH] Small performance boost for dragging within containers --- src/lib/components/AccordionContainer.svelte | 4 ++-- src/lib/components/BlockContainer.svelte | 8 ++++---- src/lib/components/TabsContainer.svelte | 6 +++--- 3 files changed, 9 insertions(+), 9 deletions(-) diff --git a/src/lib/components/AccordionContainer.svelte b/src/lib/components/AccordionContainer.svelte index ca86d8f..279aafe 100644 --- a/src/lib/components/AccordionContainer.svelte +++ b/src/lib/components/AccordionContainer.svelte @@ -25,7 +25,7 @@ export let isMobile: boolean = false; let isOpen: Writable | null = null; - let children: IDragItem[] | null = null; + let children: IDragItem[] = []; const flipDurationMs = 100; let selectedIndex: number = 0; @@ -61,7 +61,7 @@ } -{#if container && Array.isArray(children)} +{#if container} {@const selected = $uiState.uiUnlocked && $selectionState.currentSelection.includes(container.id)}
| null = null; - let children: IDragItem[] | null = null; + let children: IDragItem[] = []; const flipDurationMs = 100; $: if (container) { @@ -35,12 +35,12 @@ } else { container = null; - children = null; + children = []; attrsChanged = null; } } else { - children = null; + children = []; attrsChanged = null } @@ -55,7 +55,7 @@ }; -{#if container && Array.isArray(children)} +{#if container} {@const selected = $uiState.uiUnlocked && $selectionState.currentSelection.includes(container.id)}
| null = null; - let children: IDragItem[] | null = null; + let children: IDragItem[] = []; const flipDurationMs = 100; let selectedIndex: number = 0; @@ -35,7 +35,7 @@ attrsChanged = container.attrsChanged } else { - children = null; + children = []; attrsChanged = null } @@ -68,7 +68,7 @@ } -{#if container && Array.isArray(children)} +{#if container} {@const selected = $uiState.uiUnlocked && $selectionState.currentSelection.includes(container.id)}